This repository was archived by the owner on Feb 15, 2023. It is now read-only.
Version bump for Dev Dependencies #202
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antony
approved these changes
Jan 6, 2021
antony
suggested changes
Jan 6, 2021
scripts/setupTypeScript.js
Outdated
| <script lang="ts"> | ||
| export let name: string; | ||
| export let name: string; |
There was a problem hiding this comment.
The style guide for Svelte is to use tabs, not spaces.
There was a problem hiding this comment.
I don't mind reverting this -- this is just Format on Save. However, where is that Svelte Style Guide documented? (I couldn't find anything.) And would that apply to this js script (since it isn't a .svelte file)? And it is commented out, so this is actually just a comment.
benmccann
reviewed
Jan 18, 2021
| "rollup": "^2.3.4", | ||
| "@rollup/plugin-commonjs": "^17.0.0", | ||
| "@rollup/plugin-node-resolve": "^11.0.0", | ||
| "rollup": "^2.35.1", |
There was a problem hiding this comment.
there's no need to change this. ^2.3.4 will get you the latest 2.x version
|
I didn't see this PR and merged #210 which had some of the same changes. If you drop the |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@rollup/plugin-commonjsand@rollup/plugin-node-resolvehas major versions released@rollup/plugin-typescriptwas 2 major versions behind, andtypescriptbumped to 4